Again I'm new to this, but why would you want closed loop to register negative RPM changes to disable it? If it did that, it would turn off closed loop if the RPMs drop and it tries to die on you- the opposite of what you want!
Swing and a miss.
Aidan's problem is closed loop turns on while he's crhsing at 1800 rpm. Closed loop can't bring 1800 rpm down to idle, because its not idle. When it actually goes to idle the idle valve duty is way too low because its been trying to slow down 1800 rpm when it shouldn't.
Pid disable rpmdot would kill closed loop if it accidentally engaged like this, and if the initial value table were tuned right then it wont stall and'll be close to the proper idle value.
I will check to see if my ms2 will disable on negative values here in a bit.
Thanks. I gotta fix what I believe is a failed clutch master cylinder, but then I'll mess around with some idle settings later. If I figure anything out I'll post it here. I have it using last value, not MAT table so I'm gonna set that up first.
The problem with use last value is that it would still stall Aidan's car. It thought 29% idle valve were proper at 1800 RPM, then he stalled. If It weren't for the startup idle valve adders the thing would try and pull 29% DC on entry next time, which we know can cause stalls. (say he saved it stalling, now the car thought it idled fine and just left CL idle, and it's going for 29% next time first ting) I think it also causes the problems we saw Curly mention the other day, that is stacking dashpot adders if you blip the throttle many times in a row.
It basically exits closed loop when you blip the throttle, then goes back in while the RPMS are on the way down. If you blip the throttle again before dashpot is gone completely you enter too high after the next blip.
Tuning the initial value table is a pain, but CL idle ain't worth anything without it. My strategy like I said earlier is never closing the valve, it always tries to apply an idle valve value based on the initial table if CL is engaged or not, that way if my dashpot isn't completely out of the way I won't be adding to it, I only ever add to the initial valve table, crazy consistent values!
I think my disable RPMdot is working on negative RPMdot values.
I also incorrectly assumed MS2 wouldn't let me set less than 200rpmdot max, I can go down to 100, and I've had it set as low as it'll go.
I dropped to around 650rpm in this log around 100 seconds and recovered using fuel and timing alone, the idle valve didn't move the whole way through. You might be able to fix the stalling, while still having dips at least.
This is my valve at the min duty cycle in 4th gear, I just pushed it into neutral and coasted. Idle DC came up before passing my CLidle target.
I don't use PID either, it suuucks. I love this dummy mode, if it's low it adds, if it's high it takes. If I tell it to slow the **** down and let things settle between adjustments, it does! I run EGO correction the same way.
Is there a flag or ADC for CLidle active in a MSL? I can't find it.