MEGAsquirt A place to collectively sort out this megasquirt gizmo

Closed loop idle too early?

Thread Tools
 
Search this Thread
 
Old 12-04-2015, 02:58 PM
  #21  
Boost Czar
iTrader: (62)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 79,493
Total Cats: 4,080
Default

you all should be using adaptive timing as well. and battery votage idle % compensation.
Braineack is offline  
Old 12-04-2015, 02:58 PM
  #22  
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
 
aidandj's Avatar
 
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
Default

I do. Though I'm just using basemap values. It helps a lot.
aidandj is offline  
Old 12-04-2015, 03:01 PM
  #23  
Elite Member
iTrader: (16)
 
patsmx5's Avatar
 
Join Date: Aug 2007
Location: Houston, TX
Posts: 9,297
Total Cats: 476
Default

Thanks for the link, interesting 1st post about need 2 or higher for the PID Delay due to a code issue. I'll try bumping it up to 2 and see if that changes anything, I did notice it not kick in with very light throttle inputs.

I dunno if it's right, but I setup the setting in the lower right box so it would go into closed loop quickly when I let off the throttle.
patsmx5 is offline  
Old 12-04-2015, 03:03 PM
  #24  
Elite Member
iTrader: (16)
 
patsmx5's Avatar
 
Join Date: Aug 2007
Location: Houston, TX
Posts: 9,297
Total Cats: 476
Default

Originally Posted by Braineack
you all should be using adaptive timing as well. and battery votage idle % compensation.
Hmm, I now see the battery voltage idle% compensation, I'll mess with that.

What is the adaptive timing, just the Idle RPM Timing Correction? I do use that actually.
patsmx5 is offline  
Old 12-04-2015, 03:11 PM
  #25  
Elite Member
iTrader: (3)
 
deezums's Avatar
 
Join Date: May 2014
Location: Kansas
Posts: 3,146
Total Cats: 201
Default

Aidan,

Try changing max decel load to a value closer to what you normally hit on overrun. I get down to 16 or so, so I've got it set at 18. This way, if for some reason CL idle activates while cruising, either PID disable RPMdot will kick it out, or the super low overrun map value will kill PID if RPMdot misses.

Also, set your TPS way negative if you need to, just try and get it so that you never start with positive TPS values. Everything else doesn't really matter, MS don't care if you are idling -2% TPS, because that's less than 1%.
deezums is offline  
Old 12-04-2015, 03:24 PM
  #26  
Retired Mech Design Engr
iTrader: (3)
 
DNMakinson's Avatar
 
Join Date: Jan 2013
Location: Seneca, SC
Posts: 5,009
Total Cats: 856
Default

I agree that it is a TPS issue.
DNMakinson is offline  
Old 12-04-2015, 04:25 PM
  #27  
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
 
aidandj's Avatar
 
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
Default

Thanks guys.
aidandj is offline  
Old 12-04-2015, 09:33 PM
  #28  
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
 
aidandj's Avatar
 
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
Default

I'm pretty sure it is a sticky throttle issue. When I slowly let off the gas it reads right around 5%. But if I blip the throttle and snap it shut then it goes back to 0.
aidandj is offline  
Old 12-04-2015, 10:18 PM
  #29  
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
 
aidandj's Avatar
 
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
Default

Ok I'm stumped.

Slowly let out throttle. TPS stuck at 4%. Can't close it any further.

Blip throttle hard, TPS back at 0%.

This only happens when the engine is running. When it is off TPS always goes to 0%.
aidandj is offline  
Old 12-05-2015, 01:19 AM
  #30  
Elite Member
iTrader: (16)
 
patsmx5's Avatar
 
Join Date: Aug 2007
Location: Houston, TX
Posts: 9,297
Total Cats: 476
Default

Originally Posted by aidandj
Ok I'm stumped.

Slowly let out throttle. TPS stuck at 4%. Can't close it any further.

Blip throttle hard, TPS back at 0%.

This only happens when the engine is running. When it is off TPS always goes to 0%.
Easy. Does it idle at same RPM, or higher when TPS reads higher? I'm sure you can logically figure out if it's a sticking throttle or TPS sensor after asking yourself this question.
patsmx5 is offline  
Old 12-05-2015, 01:22 AM
  #31  
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
 
aidandj's Avatar
 
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
Default

It idles higher because closed loop idle doesn't kick in when its stuck at 4%. But otherwise its the same. I pushed as hard as I could to close it and no change. Until I bliped the throttle.

I'm going to scope voltage tomorrow.
aidandj is offline  
Old 12-05-2015, 01:44 AM
  #32  
Elite Member
iTrader: (16)
 
patsmx5's Avatar
 
Join Date: Aug 2007
Location: Houston, TX
Posts: 9,297
Total Cats: 476
Default

Originally Posted by aidandj
It idles higher because closed loop idle doesn't kick in when its stuck at 4%. But otherwise its the same. I pushed as hard as I could to close it and no change. Until I bliped the throttle.

I'm going to scope voltage tomorrow.
Well yeah have idle control off to test.

But if you say it doesn't change then TPS is your problem.
patsmx5 is offline  
Old 12-05-2015, 09:12 AM
  #33  
Boost Czar
iTrader: (62)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 79,493
Total Cats: 4,080
Default

try adjusting the TPS like i suggested. it could verywell be the tps needle thing is getting stuck and not the TB.

Last edited by Braineack; 12-05-2015 at 09:24 AM.
Braineack is offline  
Old 12-05-2015, 09:22 AM
  #34  
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
 
aidandj's Avatar
 
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
Default

Originally Posted by Braineack
try adjusting the TPS like i suggested.
Adjusting it how.
aidandj is offline  
Old 12-05-2015, 09:24 AM
  #35  
Boost Czar
iTrader: (62)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 79,493
Total Cats: 4,080
Default

Originally Posted by aidandj
Adjusting it how.
go find the damn post. hint post #8
Braineack is offline  
Old 12-05-2015, 09:44 AM
  #36  
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
 
aidandj's Avatar
 
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
Default

Originally Posted by Braineack
go find the damn post. hint post #8
its too early.
aidandj is offline  
Old 12-05-2015, 09:54 AM
  #37  
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
 
aidandj's Avatar
 
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
Default

I'll try that. It's already adjuste d in the middle somewhat. About 360-900 on the ADC.

I turned lag off and there is barely any noise when just sitting.
aidandj is offline  
Old 12-05-2015, 12:54 PM
  #38  
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
 
aidandj's Avatar
 
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
Default

I think there is a bug in the MS 3 code. It doesn't register negative rpm changes when looking at the PID disable.

Can someone confirm that it's different in ms2 code.

Test:

Set idle activation threshold to like 50% so you can get it to activate while driving.

Then get it to idle at part throttle. Set PID disable rpm dot to 300-400. Increase revs slower than your disable rpmdot and watch idle stay active. Increase faster than rpmdot and watch it disable. Now do the same with negative rpmsot. I did it by getting idle active while driving in a low gear, and then push in the clutch. My revs dropped and idle stayed on. Shouldn't it turn off?
aidandj is offline  
Old 12-05-2015, 02:02 PM
  #39  
Elite Member
iTrader: (16)
 
patsmx5's Avatar
 
Join Date: Aug 2007
Location: Houston, TX
Posts: 9,297
Total Cats: 476
Default

Again I'm new to this, but why would you want closed loop to register negative RPM changes to disable it? If it did that, it would turn off closed loop if the RPMs drop and it tries to die on you- the opposite of what you want!
patsmx5 is offline  
Old 12-05-2015, 02:06 PM
  #40  
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
 
aidandj's Avatar
 
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
Default

If it drops too fast I want it to exit closed loop and go back to my initial value table+dashpot. Because something bad is happening
aidandj is offline  


Quick Reply: Closed loop idle too early?



All times are GMT -4. The time now is 04:59 AM.