MEGAsquirt A place to collectively sort out this megasquirt gizmo

MS2 AC Idle Up Code

Thread Tools
 
Search this Thread
 
Old 10-06-2011, 03:00 AM
  #1  
Junior Member
Thread Starter
iTrader: (1)
 
gslender's Avatar
 
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Default MS2 AC Idle Up Code

Hi,

For those with MS2 systems, I'm working on establishing a firmware release that contains code for AC Idle Up.

Following the progress and provide your thoughts here... http://www.msextra.com/forums/viewto...p?f=91&t=42485

G
gslender is offline  
Old 10-08-2011, 10:52 PM
  #2  
Junior Member
Thread Starter
iTrader: (1)
 
gslender's Avatar
 
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Default

Test code has been posted... which works... oh yeah!!

Based on 3.1.3 code and include configurable delay.

http://www.msextra.com/forums/viewto...299164#p299164
gslender is offline  
Old 10-10-2011, 10:35 AM
  #3  
I'm Miserable!
 
Techsalvager's Avatar
 
Join Date: Jun 2009
Location: albany, ga
Posts: 1,866
Total Cats: 0
Default

I wonder if the ecu disengages the AC at full throttle or above said TPS position or maybe its part of an external. If it does disengage the ac, I think thats another thing that would need implemented.

I have to say good work!
Techsalvager is offline  
Old 10-10-2011, 10:39 AM
  #4  
Elite Member
iTrader: (1)
 
richyvrlimited's Avatar
 
Join Date: Jun 2006
Location: Warrington/Birmingham
Posts: 2,642
Total Cats: 42
Default

It does and it already is.
richyvrlimited is offline  
Old 10-10-2011, 03:58 PM
  #5  
Junior Member
Thread Starter
iTrader: (1)
 
gslender's Avatar
 
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Default

Originally Posted by Techsalvager
I think thats another thing that would need implemented.

I have to say good work!
Using my firmware you can. Just setup another AND condition to be TPS < 90 and the AC (via WLED) will only activate when the timer hits your value AND when the throttle is under WOT. if you don't have a VTPS you can use rpm or kpa to simulate what high load you don't want the AC to engage under.

So cool.

G
gslender is offline  
Old 10-10-2011, 04:29 PM
  #6  
I'm Miserable!
 
Techsalvager's Avatar
 
Join Date: Jun 2009
Location: albany, ga
Posts: 1,866
Total Cats: 0
Default

gslender yeah I didn't see it until I read the first post.
Techsalvager is offline  
Old 10-11-2011, 05:04 PM
  #7  
Newb
 
sparkstack's Avatar
 
Join Date: May 2011
Posts: 30
Total Cats: 0
Default

I've found that if i enter the number 3 in the battery factor my car dies and won't start again until it's changed back to 2 or 4.

Any reason for this?
sparkstack is offline  
Old 10-11-2011, 05:35 PM
  #8  
Junior Member
 
Greg G's Avatar
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Could you post a log? Wonder if it affects cranking idle valve duty..
Greg G is offline  
Old 10-11-2011, 05:45 PM
  #9  
Newb
 
sparkstack's Avatar
 
Join Date: May 2011
Posts: 30
Total Cats: 0
Default

two attached
Attached Files
File Type: msl
idle up bf set to 2.msl (199.4 KB, 135 views)
File Type: msl
idle up bf set to 3.msl (252.5 KB, 142 views)
sparkstack is offline  
Old 10-11-2011, 05:53 PM
  #10  
Junior Member
Thread Starter
iTrader: (1)
 
gslender's Avatar
 
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Default

I think I know what it is... an undated firmware is coming in a few minutes. Would be great if you can confirm fixed... hang on.
gslender is offline  
Old 10-11-2011, 05:57 PM
  #11  
Junior Member
Thread Starter
iTrader: (1)
 
gslender's Avatar
 
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Default

try this firmware. the ini hasn't changed.
Attached Files
File Type: zip
gslender is offline  
Old 10-11-2011, 06:39 PM
  #12  
Junior Member
 
Greg G's Avatar
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Sparkstack-- dunno about the cranking issue, but it looks like the battery idle valve correction is too strong, possible contributing to the oscillation you get. Have you tried a factor of 1 or lower?

My concept of it is that it should catch any RPM dip due to large drops in voltage, and should have minimal impact during steady state idling. Could the correction ramp up as it gets farther from 13.2? Or perhaps a dead zone/minimal batt voltage parameter be used? Will try it on my car in a bit, and post back.
Greg G is offline  
Old 10-11-2011, 07:03 PM
  #13  
Junior Member
Thread Starter
iTrader: (1)
 
gslender's Avatar
 
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Default

Originally Posted by Greg G
My concept of it is that it should catch any RPM dip due to large drops in voltage, and should have minimal impact during steady state idling. Could the correction ramp up as it gets farther from 13.2? Or perhaps a dead zone/minimal batt voltage parameter be used? Will try it on my car in a bit, and post back.
Mmmm, well there is obviously scope to get this mod included in my firmware, but I just need guidance on what you are looking to fix. I personally don't see any issues with lights, car audio with voltage drops that are causing idle rpm dip, but that might be because I'm accepting of very slight fluctuations and hunting - which was there before with the stock ECU.

Telling me large drops, dead zones, minimal batt voltage don't help - as without specific values, my interpretation on what minimal is, might not be yours ....

In saying that, if you can describe what you want (ie when voltage goes to X please make duty go to Y, and give me a few points on a table, I can work out a formula that can model this and add some element of adjustment factor to account for other peoples needs etc.

G
gslender is offline  
Old 10-11-2011, 07:15 PM
  #14  
Junior Member
 
Greg G's Avatar
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Got it. Will test it out and sift through the data! Thanks!
Greg G is offline  
Old 10-11-2011, 07:38 PM
  #15  
Junior Member
Thread Starter
iTrader: (1)
 
gslender's Avatar
 
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Default

...also, there is non-linear battery correction already included (recent update) for the injector PW, so might be best to confirm operation with my battery duty fix disabled (set to zero) as realistically I'm unlikely to catch-and-stop a voltage drop quickly anyway and the injector stuff might be the better outcome... assuming you only wish to restore correct idle operations when voltage drops to 10V instead of 13.2V ???

G
gslender is offline  
Old 10-11-2011, 07:39 PM
  #16  
Junior Member
Thread Starter
iTrader: (1)
 
gslender's Avatar
 
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Default

...eg Battery correction factor in opening time
gslender is offline  
Old 10-11-2011, 07:42 PM
  #17  
Newb
 
sparkstack's Avatar
 
Join Date: May 2011
Posts: 30
Total Cats: 0
Default

Originally Posted by gslender
Mmmm, well there is obviously scope to get this mod included in my firmware, but I just need guidance on what you are looking to fix. I personally don't see any issues with lights, car audio with voltage drops that are causing idle rpm dip, but that might be because I'm accepting of very slight fluctuations and hunting - which was there before with the stock ECU.
I'd go along with that. My bone stock 90 never had a rock solid idle, it always fluctuated a little, which is probably due to the narrowband sensor. It usually idled between 14.2 and 15.7, the warmer it got the narrower the swing.

Now i'd love a rock solid 850rpm (1000rpm with AC) idle with the MSQ, but right now i'm not there and i'm not going to loose sleep over it. Prior to this firmware i either had a 1200rpm base idle or knock when the AC was on. My main priority now i've got this far (thanks gslender) is to drive it around and tune the rest of the map. I'll come back to idle later.
sparkstack is offline  
Old 10-11-2011, 08:18 PM
  #18  
Junior Member
Thread Starter
iTrader: (1)
 
gslender's Avatar
 
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Default

So sparkstack, did that revised firmware fix the bug with duty factor set to 2/3/4 etc.... ?

G
gslender is offline  
Old 10-11-2011, 08:46 PM
  #19  
Junior Member
 
Greg G's Avatar
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Ok quick report on the battery idle correction- works great, my only request is that we be able to input correction factors in tenths. My sweet spot is somewhere between 1 and 2. Small rpm dip if factor is 1- if factor is 2, the rpm actually rises when the fan goes on! But yippee it works! No issue with steady state idle, it is the smoothest it's been in an long time.

There some more smoothness to be had with tapering the PID values down to match the new idle control features. Will post data and graphs in a few hours, they are quite interesting.

EDIT: graphs/logs posted on my idle thread so as not to pollute this one

Last edited by Greg G; 10-12-2011 at 08:41 AM.
Greg G is offline  
Old 10-11-2011, 10:00 PM
  #20  
Newb
 
sparkstack's Avatar
 
Join Date: May 2011
Posts: 30
Total Cats: 0
Default

Originally Posted by gslender
So sparkstack, did that revised firmware fix the bug with duty factor set to 2/3/4 etc.... ?

G
Haven't tested it yet. I'll test it out tomorrow when i get home.
sparkstack is offline  


Quick Reply: MS2 AC Idle Up Code



All times are GMT -4. The time now is 09:20 PM.