Closed loop idle too early?
#23
Thanks for the link, interesting 1st post about need 2 or higher for the PID Delay due to a code issue. I'll try bumping it up to 2 and see if that changes anything, I did notice it not kick in with very light throttle inputs.
I dunno if it's right, but I setup the setting in the lower right box so it would go into closed loop quickly when I let off the throttle.
I dunno if it's right, but I setup the setting in the lower right box so it would go into closed loop quickly when I let off the throttle.
#25
Aidan,
Try changing max decel load to a value closer to what you normally hit on overrun. I get down to 16 or so, so I've got it set at 18. This way, if for some reason CL idle activates while cruising, either PID disable RPMdot will kick it out, or the super low overrun map value will kill PID if RPMdot misses.
Also, set your TPS way negative if you need to, just try and get it so that you never start with positive TPS values. Everything else doesn't really matter, MS don't care if you are idling -2% TPS, because that's less than 1%.
Try changing max decel load to a value closer to what you normally hit on overrun. I get down to 16 or so, so I've got it set at 18. This way, if for some reason CL idle activates while cruising, either PID disable RPMdot will kick it out, or the super low overrun map value will kill PID if RPMdot misses.
Also, set your TPS way negative if you need to, just try and get it so that you never start with positive TPS values. Everything else doesn't really matter, MS don't care if you are idling -2% TPS, because that's less than 1%.
#28
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
I'm pretty sure it is a sticky throttle issue. When I slowly let off the gas it reads right around 5%. But if I blip the throttle and snap it shut then it goes back to 0.
#29
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
Ok I'm stumped.
Slowly let out throttle. TPS stuck at 4%. Can't close it any further.
Blip throttle hard, TPS back at 0%.
This only happens when the engine is running. When it is off TPS always goes to 0%.
Slowly let out throttle. TPS stuck at 4%. Can't close it any further.
Blip throttle hard, TPS back at 0%.
This only happens when the engine is running. When it is off TPS always goes to 0%.
#31
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
It idles higher because closed loop idle doesn't kick in when its stuck at 4%. But otherwise its the same. I pushed as hard as I could to close it and no change. Until I bliped the throttle.
I'm going to scope voltage tomorrow.
I'm going to scope voltage tomorrow.
#37
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
I'll try that. It's already adjuste d in the middle somewhat. About 360-900 on the ADC.
I turned lag off and there is barely any noise when just sitting.
I turned lag off and there is barely any noise when just sitting.
#38
SADFab Destructive Testing Engineer
Thread Starter
iTrader: (5)
Join Date: Apr 2014
Location: Beaverton, USA
Posts: 18,642
Total Cats: 1,866
I think there is a bug in the MS 3 code. It doesn't register negative rpm changes when looking at the PID disable.
Can someone confirm that it's different in ms2 code.
Test:
Set idle activation threshold to like 50% so you can get it to activate while driving.
Then get it to idle at part throttle. Set PID disable rpm dot to 300-400. Increase revs slower than your disable rpmdot and watch idle stay active. Increase faster than rpmdot and watch it disable. Now do the same with negative rpmsot. I did it by getting idle active while driving in a low gear, and then push in the clutch. My revs dropped and idle stayed on. Shouldn't it turn off?
Can someone confirm that it's different in ms2 code.
Test:
Set idle activation threshold to like 50% so you can get it to activate while driving.
Then get it to idle at part throttle. Set PID disable rpm dot to 300-400. Increase revs slower than your disable rpmdot and watch idle stay active. Increase faster than rpmdot and watch it disable. Now do the same with negative rpmsot. I did it by getting idle active while driving in a low gear, and then push in the clutch. My revs dropped and idle stayed on. Shouldn't it turn off?