MS2 AC Idle Up Code - Page 4 - Miata Turbo Forum - Boost cars, acquire cats.

Welcome to Miataturbo.net   Members
 


MEGAsquirt A place to collectively sort out this megasquirt gizmo

Reply
 
 
 
LinkBack Thread Tools
Old 10-24-2011, 09:39 AM   #61
Junior Member
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

If it doesn't use sequential, then V3 is fine
Greg G is offline   Reply With Quote
Old 10-24-2011, 09:48 AM   #62
Boost Czar
iTrader: (61)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 72,848
Total Cats: 1,788
Default

it does. I was going to have him load the new firmware once it came out. I set the rev limiter to 5900.



positive spin: I loaded it for someone else over the weekend and he's really happy with the function.

Last edited by Braineack; 10-24-2011 at 10:10 AM.
Braineack is online now   Reply With Quote
Old 10-24-2011, 09:57 AM   #63
Junior Member
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Best function ever
Greg G is offline   Reply With Quote
Old 10-24-2011, 10:11 AM   #64
Boost Czar
iTrader: (61)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 72,848
Total Cats: 1,788
Default

I've been enjoying it for over a year now
Braineack is online now   Reply With Quote
Old 10-24-2011, 10:22 AM   #65
Junior Member
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Booo

Anyway better late than never (wow has there ever been a more appropriate time to use that?)
Greg G is offline   Reply With Quote
Old 10-28-2011, 10:19 PM   #66
Junior Member
 
Join Date: Aug 2011
Location: Maryland
Posts: 48
Total Cats: 0
Default

Quote:
Originally Posted by Braineack View Post
it does. I was going to have him load the new firmware once it came out. I set the rev limiter to 5900.



positive spin: I loaded it for someone else over the weekend and he's really happy with the function.
I think that would be me. It's kind of weird to hear the compressor engaging and cold air coming out of the vents with absolutely no change in RPM. Really, really nice.

Since the idle droop with the AC, i started paying attention to other (stock) cars and some are better, some are worse but I still yet have to drive a stock car (not necessarily a miata) where the idle is not upset at least a little bit by the ac kicking in.

thanks, brain.
self is offline   Reply With Quote
Old 10-28-2011, 10:39 PM   #67
Junior Member
Thread Starter
iTrader: (1)
 
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Default

Glad that MegaSquirtSanta's presents are liked by all

The elves and I have been busy working on some new presents and it should be Xmas time again soon.

Cheers
MegaSquirtSanta (aka G)
gslender is offline   Reply With Quote
Old 10-29-2011, 04:51 AM   #68
Junior Member
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Now I'm an elf????



Almost nailed it. Hard to tell when the AC compressor engages (listen for the click of the switch), the fans are more noticeable because the RPMs go *up* a little when they engage! The slight surge on AC disengagement is due to my high D reacting to the idle duty dropping. Will tune that out.
Greg G is offline   Reply With Quote
Old 11-01-2011, 12:42 AM   #69
Junior Member
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Done. Stick a fork in it

Version 6c adds the "graceful exit" function, as follows: When AC signal turns off, idle adders turn off immediately, while status 4 jumps to a preset value and counts DOWN at a preset rate. Thus turning off accessories in reverse order (unless you play with hysteresis). Timed right, you will get an RPM drop and turn the AC compressor off just when it drops, so they cancel each other out. Brilliant! :yeah!:

Name:  11111gracefulexit.png
Views: 6
Size:  122.2 KB



Sorry for the quality, I only had my GoPro on hand.

Last edited by Greg G; 11-01-2011 at 04:43 AM.
Greg G is offline   Reply With Quote
Old 11-01-2011, 02:49 PM   #70
Junior Member
 
Join Date: Apr 2010
Posts: 107
Total Cats: 0
Default

Awesome. How do I get my hands on 6c?
bearda is offline   Reply With Quote
Old 11-01-2011, 06:25 PM   #71
Junior Member
Thread Starter
iTrader: (1)
 
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Default

I'm going to release 6c under the MegaSquirtSanta name very shortly (in like a few days)... in fact I'm just putting the gift wrapping on it right now ;-)
gslender is offline   Reply With Quote
Old 11-02-2011, 10:58 PM   #72
Newb
 
Join Date: May 2011
Posts: 30
Total Cats: 0
Default

Seems it's not fully cooked yet. Just loaded it - video showing what happens here:

http://vimeo.com/31523057

Last edited by sparkstack; 11-02-2011 at 11:34 PM.
sparkstack is offline   Reply With Quote
Old 11-03-2011, 12:37 AM   #73
Junior Member
Thread Starter
iTrader: (1)
 
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Default

Quote:
Originally Posted by sparkstack View Post
Seems it's not fully cooked yet. Just loaded it - video showing what happens here:

http://vimeo.com/31523057
Can you elaborate? The video didn't outline what specifically is not working.

Also, what are your Output settings?

G
gslender is offline   Reply With Quote
Old 11-03-2011, 01:56 AM   #74
Junior Member
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

AC idle up of 19 is way high! I have mine at 10-11. Plus your idle valve is going way higher than that! What are your settings for min/max duty, and min/max rpm? And your pid settings?

The high AC idle up migh be driving the pid code nuts trying to bring it down to target. I don't know why it opens up even further though.

I think the ve table needs work too. Suggest creating another thread for your issues...with a log and msq. Hard to really see what the issues are from a video.

Last edited by Greg G; 11-03-2011 at 02:41 AM.
Greg G is offline   Reply With Quote
Old 11-03-2011, 08:23 AM   #75
Newb
 
Join Date: May 2011
Posts: 30
Total Cats: 0
Default

19 works for me and gives me a nice 1980rpm idle while the AC Is on. You can see that midway through the video.

It's plain to see what is happening. Your code adds the initial requested duty, but then inexplicably adds it again. And again. And again. Until status 4 reaches target, by which time my idle valve is at 100%. Once status 4 reaches 120 it drops the idle back down to the initial requested value and it idles at 1980+- 10.

I'll admit I'm still ironing out parts of my tune, but the idle valve settings are set as a result of running the valve test, and my VE table while still needing a little work is not the issue here.

The issue is that your code (or some internal code) keeps adding the AC idle duty setting while ramping up status 4.

Version 5 of your code worked fine. My Pid is not freaking out. It only freaks out when your code tells it to.
sparkstack is offline   Reply With Quote
Old 11-03-2011, 10:29 AM   #76
Junior Member
 
Join Date: Apr 2010
Posts: 107
Total Cats: 0
Default

Quote:
Originally Posted by sparkstack View Post
19 works for me and gives me a nice 1980rpm idle while the AC Is on. You can see that midway through the video.
Why do you want a 1980 RPM idle? Isn't that WAY over your idle rpm target? Maybe the PID is freaking out because you're so far off from where it's trying to be and it hasn't been tuned for those exremes?
bearda is offline   Reply With Quote
Old 11-03-2011, 10:59 AM   #77
Boost Czar
iTrader: (61)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 72,848
Total Cats: 1,788
Default

I think he meant 1180 -- so far as I can tell in the video, that's where it rest when he's at 40% DC. But still, that's higher than you really want. 12% adder is the perfect number for a 90-93.


and yes it probably is confusing the code since you're driving the valve up so much and not adding to your target. what are your PID values?

But I've seen this behavior on my MS3 before when I introduced a short into my a/c input. The MS would just keep applying the adder until the idle valve was stuck open.
Braineack is online now   Reply With Quote
Old 11-03-2011, 11:01 AM   #78
Junior Member
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

I think he may be getting in and out of closed loop and eventually locked out?

I was also thinking of some sort of hardware issue, but wouldn't that reset the status4 count?

It's be much easier to figure out with actual msq and msl files. Otherwise we're just guessing.

Last edited by Greg G; 11-03-2011 at 11:12 AM.
Greg G is offline   Reply With Quote
Old 11-03-2011, 01:45 PM   #79
Newb
 
Join Date: May 2011
Posts: 30
Total Cats: 0
Default

MSQ attached.
Also attached is a log from yesterday. Same settings just AC-Idle v5. I'll generate a new log tonight when i get out the office.

Now, to answer the various questions.

1: I'm not going out of closed loop and my PID is not going "crazy" during normal operation. It goes crazy when the AC is engaged with this version of the Mod.

2: Previous version (with the exact same tune and setting of 19.1%) and my car idles perfect with the AC on or off and in closed loop.

3: Watch the video again. Right a the beginning ( i didn't show enough) i'm at 28-29% PWM with an 850+-20 idle. Then the AC kicks in and the PWM goes up to 40% (3 seconds in on the video) which is what i'm calling for.

4: Inexplicably, the code keeps adding 19% every few seconds until status 4 reaches 120. Then after a pause while it tries to get my idle valve to go past 100% it finally allows it to drop down to the initial 40%PWM again - and my car idles at 40% PWM and 1200 rpm. Right where i want it, until the AC kicks in again. Rinse repeat.


Incidentally, why could we not have a version of this mod that removes all the superfluous PID% gains and battery volt droop code and just have a simple system that changes the Idle RPM to a value specified.

For example. If i want a 800rpm idle without ac and the car warmed up vs a 1200rpm idle with the AC on, have it so it just changes between the two in the closed loop idle target table. Sounds like a simpler way of doing it. But i don't program.
Attached Files
File Type: zip Archive.zip (883.0 KB, 30 views)
sparkstack is offline   Reply With Quote
Old 11-03-2011, 02:08 PM   #80
Junior Member
 
Join Date: Apr 2010
Posts: 107
Total Cats: 0
Default

Quote:
Originally Posted by sparkstack View Post
For example. If i want a 800rpm idle without ac and the car warmed up vs a 1200rpm idle with the AC on, have it so it just changes between the two in the closed loop idle target table. Sounds like a simpler way of doing it. But i don't program.
Because most of us don't want a 1200 rpm idle. We want an 850 RPM idle all the time, if the AC is on or off. The response wouldn't be quite as fast, either. By changing the idle duty you get a pretty quick response, changing the RPM target still means you have to go through the PID control loop, which can't do anything to speed things up by comparison but can dampen the response.
bearda is offline   Reply With Quote
 
 
Reply

Related Topics
Thread Thread Starter Forum Replies Last Post
Back to Stock Part Out!! Turbo Parts, MS2 Enhanced 01-05, Suspension, and MOAR! StratoBlue1109 Miata parts for sale/trade 16 10-02-2015 10:39 AM
Time to start learning and play with tuning The Gleas MEGAsquirt 3 10-01-2015 10:30 AM
Low oil pressure after 1.8 swap and new turbo setup JesseTheNoob DIY Turbo Discussion 15 09-30-2015 03:44 PM
why is my car running like pewp? (tune/datalog) itsMikey MSPNP 3 09-28-2015 07:40 AM
mslabs MS2 - Idle control issue ndragun MEGAsquirt 0 09-20-2015 11:28 PM


Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off



All times are GMT -4. The time now is 09:15 AM.