MS2 AC Idle Up Code
#62
Boost Czar
iTrader: (62)
Join Date: May 2005
Location: Chantilly, VA
Posts: 79,499
Total Cats: 4,080
it does. I was going to have him load the new firmware once it came out. I set the rev limiter to 5900.
positive spin: I loaded it for someone else over the weekend and he's really happy with the function.
positive spin: I loaded it for someone else over the weekend and he's really happy with the function.
Last edited by Braineack; 10-24-2011 at 09:10 AM.
#66
Since the idle droop with the AC, i started paying attention to other (stock) cars and some are better, some are worse but I still yet have to drive a stock car (not necessarily a miata) where the idle is not upset at least a little bit by the ac kicking in.
thanks, brain.
#67
Junior Member
Thread Starter
iTrader: (1)
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Glad that MegaSquirtSanta's presents are liked by all
The elves and I have been busy working on some new presents and it should be Xmas time again soon.
Cheers
MegaSquirtSanta (aka G)
The elves and I have been busy working on some new presents and it should be Xmas time again soon.
Cheers
MegaSquirtSanta (aka G)
#68
Now I'm an elf????
Almost nailed it. Hard to tell when the AC compressor engages (listen for the click of the switch), the fans are more noticeable because the RPMs go *up* a little when they engage! The slight surge on AC disengagement is due to my high D reacting to the idle duty dropping. Will tune that out.
Almost nailed it. Hard to tell when the AC compressor engages (listen for the click of the switch), the fans are more noticeable because the RPMs go *up* a little when they engage! The slight surge on AC disengagement is due to my high D reacting to the idle duty dropping. Will tune that out.
#69
Done. Stick a fork in it
Version 6c adds the "graceful exit" function, as follows: When AC signal turns off, idle adders turn off immediately, while status 4 jumps to a preset value and counts DOWN at a preset rate. Thus turning off accessories in reverse order (unless you play with hysteresis). Timed right, you will get an RPM drop and turn the AC compressor off just when it drops, so they cancel each other out. Brilliant! :yeah!:
Sorry for the quality, I only had my GoPro on hand.
Version 6c adds the "graceful exit" function, as follows: When AC signal turns off, idle adders turn off immediately, while status 4 jumps to a preset value and counts DOWN at a preset rate. Thus turning off accessories in reverse order (unless you play with hysteresis). Timed right, you will get an RPM drop and turn the AC compressor off just when it drops, so they cancel each other out. Brilliant! :yeah!:
Sorry for the quality, I only had my GoPro on hand.
Last edited by Greg G; 11-01-2011 at 03:43 AM.
#72
Seems it's not fully cooked yet. Just loaded it - video showing what happens here:
http://vimeo.com/31523057
http://vimeo.com/31523057
Last edited by sparkstack; 11-02-2011 at 10:34 PM.
#73
Junior Member
Thread Starter
iTrader: (1)
Join Date: Jun 2011
Location: Australia
Posts: 178
Total Cats: 3
Seems it's not fully cooked yet. Just loaded it - video showing what happens here:
http://vimeo.com/31523057
http://vimeo.com/31523057
Also, what are your Output settings?
G
#74
AC idle up of 19 is way high! I have mine at 10-11. Plus your idle valve is going way higher than that! What are your settings for min/max duty, and min/max rpm? And your pid settings?
The high AC idle up migh be driving the pid code nuts trying to bring it down to target. I don't know why it opens up even further though.
I think the ve table needs work too. Suggest creating another thread for your issues...with a log and msq. Hard to really see what the issues are from a video.
The high AC idle up migh be driving the pid code nuts trying to bring it down to target. I don't know why it opens up even further though.
I think the ve table needs work too. Suggest creating another thread for your issues...with a log and msq. Hard to really see what the issues are from a video.
Last edited by Greg G; 11-03-2011 at 01:41 AM.
#75
19 works for me and gives me a nice 1980rpm idle while the AC Is on. You can see that midway through the video.
It's plain to see what is happening. Your code adds the initial requested duty, but then inexplicably adds it again. And again. And again. Until status 4 reaches target, by which time my idle valve is at 100%. Once status 4 reaches 120 it drops the idle back down to the initial requested value and it idles at 1980+- 10.
I'll admit I'm still ironing out parts of my tune, but the idle valve settings are set as a result of running the valve test, and my VE table while still needing a little work is not the issue here.
The issue is that your code (or some internal code) keeps adding the AC idle duty setting while ramping up status 4.
Version 5 of your code worked fine. My Pid is not freaking out. It only freaks out when your code tells it to.
It's plain to see what is happening. Your code adds the initial requested duty, but then inexplicably adds it again. And again. And again. Until status 4 reaches target, by which time my idle valve is at 100%. Once status 4 reaches 120 it drops the idle back down to the initial requested value and it idles at 1980+- 10.
I'll admit I'm still ironing out parts of my tune, but the idle valve settings are set as a result of running the valve test, and my VE table while still needing a little work is not the issue here.
The issue is that your code (or some internal code) keeps adding the AC idle duty setting while ramping up status 4.
Version 5 of your code worked fine. My Pid is not freaking out. It only freaks out when your code tells it to.
#77
Boost Czar
iTrader: (62)
Join Date: May 2005
Location: Chantilly, VA
Posts: 79,499
Total Cats: 4,080
I think he meant 1180 -- so far as I can tell in the video, that's where it rest when he's at 40% DC. But still, that's higher than you really want. 12% adder is the perfect number for a 90-93.
and yes it probably is confusing the code since you're driving the valve up so much and not adding to your target. what are your PID values?
But I've seen this behavior on my MS3 before when I introduced a short into my a/c input. The MS would just keep applying the adder until the idle valve was stuck open.
and yes it probably is confusing the code since you're driving the valve up so much and not adding to your target. what are your PID values?
But I've seen this behavior on my MS3 before when I introduced a short into my a/c input. The MS would just keep applying the adder until the idle valve was stuck open.
#78
I think he may be getting in and out of closed loop and eventually locked out?
I was also thinking of some sort of hardware issue, but wouldn't that reset the status4 count?
It's be much easier to figure out with actual msq and msl files. Otherwise we're just guessing.
I was also thinking of some sort of hardware issue, but wouldn't that reset the status4 count?
It's be much easier to figure out with actual msq and msl files. Otherwise we're just guessing.
Last edited by Greg G; 11-03-2011 at 10:12 AM.
#79
MSQ attached.
Also attached is a log from yesterday. Same settings just AC-Idle v5. I'll generate a new log tonight when i get out the office.
Now, to answer the various questions.
1: I'm not going out of closed loop and my PID is not going "crazy" during normal operation. It goes crazy when the AC is engaged with this version of the Mod.
2: Previous version (with the exact same tune and setting of 19.1%) and my car idles perfect with the AC on or off and in closed loop.
3: Watch the video again. Right a the beginning ( i didn't show enough) i'm at 28-29% PWM with an 850+-20 idle. Then the AC kicks in and the PWM goes up to 40% (3 seconds in on the video) which is what i'm calling for.
4: Inexplicably, the code keeps adding 19% every few seconds until status 4 reaches 120. Then after a pause while it tries to get my idle valve to go past 100% it finally allows it to drop down to the initial 40%PWM again - and my car idles at 40% PWM and 1200 rpm. Right where i want it, until the AC kicks in again. Rinse repeat.
Incidentally, why could we not have a version of this mod that removes all the superfluous PID% gains and battery volt droop code and just have a simple system that changes the Idle RPM to a value specified.
For example. If i want a 800rpm idle without ac and the car warmed up vs a 1200rpm idle with the AC on, have it so it just changes between the two in the closed loop idle target table. Sounds like a simpler way of doing it. But i don't program.
Also attached is a log from yesterday. Same settings just AC-Idle v5. I'll generate a new log tonight when i get out the office.
Now, to answer the various questions.
1: I'm not going out of closed loop and my PID is not going "crazy" during normal operation. It goes crazy when the AC is engaged with this version of the Mod.
2: Previous version (with the exact same tune and setting of 19.1%) and my car idles perfect with the AC on or off and in closed loop.
3: Watch the video again. Right a the beginning ( i didn't show enough) i'm at 28-29% PWM with an 850+-20 idle. Then the AC kicks in and the PWM goes up to 40% (3 seconds in on the video) which is what i'm calling for.
4: Inexplicably, the code keeps adding 19% every few seconds until status 4 reaches 120. Then after a pause while it tries to get my idle valve to go past 100% it finally allows it to drop down to the initial 40%PWM again - and my car idles at 40% PWM and 1200 rpm. Right where i want it, until the AC kicks in again. Rinse repeat.
Incidentally, why could we not have a version of this mod that removes all the superfluous PID% gains and battery volt droop code and just have a simple system that changes the Idle RPM to a value specified.
For example. If i want a 800rpm idle without ac and the car warmed up vs a 1200rpm idle with the AC on, have it so it just changes between the two in the closed loop idle target table. Sounds like a simpler way of doing it. But i don't program.
#80
Because most of us don't want a 1200 rpm idle. We want an 850 RPM idle all the time, if the AC is on or off. The response wouldn't be quite as fast, either. By changing the idle duty you get a pretty quick response, changing the RPM target still means you have to go through the PID control loop, which can't do anything to speed things up by comparison but can dampen the response.