MEGAsquirt A place to collectively sort out this megasquirt gizmo

DIYPNP install: inital tuning

Thread Tools
 
Search this Thread
 
Old 06-17-2011, 03:02 PM
  #261  
Junior Member
 
muythaibxr's Avatar
 
Join Date: May 2007
Location: Columbia, MD
Posts: 248
Total Cats: 0
Default

I'll post on msextra when I have alpha code ready. I guess I can post here too.

Ken
muythaibxr is offline  
Old 06-20-2011, 01:05 AM
  #262  
Junior Member
Thread Starter
 
Greg G's Avatar
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

While waiting for the updated code, I went ahead and added a second air solenoid wired to turn on with AC signal (again, the AC compressor is on a 1 second delay relay, effectively giving me a feedforward mechanism of sorts).

Now the extra air is more pronounced. From idle of 1050, when AC switch is turned on, the 2 solenoids raise the idle to ~1290, AC clutch engages. RPMs drop to ~900-1000 with just 1 big dip. Minimal overshoot, settles at ~1050-1100 idle. Fairly solid. And I haven't tuned the PID settings yet!

Name:  620abvalves.png
Views: 58
Size:  19.9 KB

This picture shows the difference with the 2 extra air solenoids vs the single solenoid (ghost lines). Not the stability of the RPMs and the stark difference in idle valve duty!
Name:  6201vs2valves.png
Views: 68
Size:  32.1 KB

The idle valve duty only responds to the initial big dip, then is pegged at minimum duty, so it's actually now fighting to bring the idle down, which is much better than the other way! I think my hysteresis settings should be reduced, that's probably another factor. The idle variation almost equals my hysteresis settings...

I think I can safely reduce the idle target to 900 now...turning on the headlights will still upset the balance, but I expect the improved code to take care of that, and perhaps even reduce the initial droop even further...

Last edited by Greg G; 06-20-2011 at 01:42 AM.
Greg G is offline  
Old 06-20-2011, 08:33 AM
  #263  
Boost Czar
iTrader: (62)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 79,493
Total Cats: 4,080
Default

now you need to time the solenoid opening better, it's happening too early. You want to make the leak start as the a/c opens up so they cancel each other out.


the second ghosted log makes me wonder about your AFRs, the spark angle and idle valve are locked solid, but its hunting around like a bitch still...makes me think the fuel needs fine tuning.
Braineack is offline  
Old 06-20-2011, 09:08 AM
  #264  
Junior Member
Thread Starter
 
Greg G's Avatar
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

That's a 1 second delay. Will try reducing it. You're running 500ms, right?
Greg G is offline  
Old 06-20-2011, 09:11 AM
  #265  
Boost Czar
iTrader: (62)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 79,493
Total Cats: 4,080
Default

something around that
Braineack is offline  
Old 06-20-2011, 10:09 AM
  #266  
Junior Member
 
muythaibxr's Avatar
 
Join Date: May 2007
Location: Columbia, MD
Posts: 248
Total Cats: 0
Default

The good news is, I got the changes made in ms3 and ms2.

More good news is I tested them in ms3 and they work.

The bad news is I left my USB->Serial converter that I use with the MS2 at work all weekend, and I'm not going back to the office until tomorrow. So I should have the ms2 changes tested tomorrow evening.

Ken
muythaibxr is offline  
Old 06-20-2011, 10:12 AM
  #267  
Boost Czar
iTrader: (62)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 79,493
Total Cats: 4,080
Default

Ken, email me the ms3 firmware and I'll play with it this afternoon.

Last edited by Braineack; 06-20-2011 at 10:26 AM.
Braineack is offline  
Old 06-20-2011, 10:21 AM
  #268  
Elite Member
iTrader: (10)
 
Reverant's Avatar
 
Join Date: Jun 2006
Location: Athens, Greece
Posts: 5,977
Total Cats: 355
Default

I tested my own firmware with said changes on the stim, seems to work well. Will test on the car later.
Reverant is offline  
Old 06-20-2011, 11:56 AM
  #269  
Junior Member
 
muythaibxr's Avatar
 
Join Date: May 2007
Location: Columbia, MD
Posts: 248
Total Cats: 0
Default

Originally Posted by Braineack
Ken, email me the ms3 firmware and I'll play with it this afternoon.
I'll be emailing it to you and y8s later today when I'm done with work.

Ken
muythaibxr is offline  
Old 06-20-2011, 11:58 AM
  #270  
Junior Member
Thread Starter
 
Greg G's Avatar
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Originally Posted by Braineack
the second ghosted log makes me wonder about your AFRs, the spark angle and idle valve are locked solid, but its hunting around like a bitch still...makes me think the fuel needs fine tuning.
The AFRs are pretty much dialed in. This pic is a comparison of the 2. The only thing that stands out- intake air temps are higher in the one with some oscillations. Also ~ 1 degree more retard (temp based?)

Name:  620iatidle.png
Views: 80
Size:  120.0 KB

Attached are the relevant logs for your perusal. And the MSQ. Lemme know if there's anything to tweak. Quick before Ken posts the updated MS3 code and you get all distracted on me
Attached Files
File Type: msq
CurrentTune.msq (79.6 KB, 167 views)
File Type: msl
2011-06-20_12.05.16.msl (111.2 KB, 94 views)
File Type: msl
2011-06-20_12.17.08abvalves.msl (180.0 KB, 149 views)
Greg G is offline  
Old 06-20-2011, 12:05 PM
  #271  
Junior Member
Thread Starter
 
Greg G's Avatar
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Originally Posted by muythaibxr
The good news is, I got the changes made in ms3 and ms2.

More good news is I tested them in ms3 and they work.

The bad news is I left my USB->Serial converter that I use with the MS2 at work all weekend, and I'm not going back to the office until tomorrow. So I should have the ms2 changes tested tomorrow evening.

Ken
Fantastic! When I do get to try it, I'll disconnect the 2nd solenoid, so we can have an apple to apples comparison and see the difference the code changes have!

Thanks for the quick work on the fix!
Greg G is offline  
Old 06-20-2011, 12:05 PM
  #272  
Boost Czar
iTrader: (62)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 79,493
Total Cats: 4,080
Default

Overlay AFR, PW, RPM, MAP.

I can't do it here.
Braineack is offline  
Old 06-20-2011, 12:11 PM
  #273  
Junior Member
Thread Starter
 
Greg G's Avatar
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Originally Posted by Braineack
Overlay AFR, PW, RPM, MAP.

I can't do it here.
Battery V is stable, no differences there.

You may be on to something! PW is fluctuating with the higher IAT...?

What setting connects the 2?

Name:  620iatidle2.png
Views: 87
Size:  110.3 KB
Greg G is offline  
Old 06-20-2011, 12:36 PM
  #274  
Boost Czar
iTrader: (62)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 79,493
Total Cats: 4,080
Default

pull up the GVE and see what the VE% value it was fueling off. maybe the fuel map just needs work. check for any gammae enrichments at the time as well. Gair or gbaro or something.
Braineack is offline  
Old 06-20-2011, 06:06 PM
  #275  
Junior Member
Thread Starter
 
Greg G's Avatar
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Originally Posted by Braineack
pull up the GVE and see what the VE% value it was fueling off. maybe the fuel map just needs work. check for any gammae enrichments at the time as well. Gair or gbaro or something.
Hmm. Small bumps in gVE corresponding to the oscillations. The stable idle had a flat GVE. But again, I didn't touch the VE tables between the 2. The only difference was IAT ~90 stable, ~120 oscillations...

Name:  620pwidle.png
Views: 79
Size:  97.5 KB

Oh I get it! I have a step in my VE table:

Here's the stable one:
Name:  620ve3idle2.png
Views: 74
Size:  186.7 KB

Here's the one with oscillations. Note the 4 cells used to calculate VE compard to the previous one using 2 cells.
Name:  620ve3idle.png
Views: 71
Size:  184.7 KB

So do I make the lower row richer, or the upper row leaner, or average them out? Any other areas in the VE table standing out? This is VEtable 3, which is used when AC is on (hardware trigger along with spartktable 3). EDIT: I think this shows I need to richen the lower rows.

Name:  620ve3idle3.png
Views: 73
Size:  187.1 KB

Hmm..so my wanting finer resolution in the idle zones actually hurt me in this case! I should pay more attention to the transitions between idle cells, since there is less room for the software to interpolate the values between cells.

Last edited by Greg G; 06-20-2011 at 06:34 PM.
Greg G is offline  
Old 06-20-2011, 06:32 PM
  #276  
Boost Czar
iTrader: (62)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 79,493
Total Cats: 4,080
Default

whats odd is it's showing it's fueling at 49-50% VE, but your maps in that area doesn't ask for that amount.


but i realize you're oscillations, now looking at the logs, aren't bad at all.

looks like we are talking +/-50RPM, min the and max RPM is really exaggerating the oscillation. Had that been on a normal log I wouldn't even had seen it.
Braineack is offline  
Old 06-20-2011, 06:36 PM
  #277  
Junior Member
Thread Starter
 
Greg G's Avatar
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Originally Posted by Braineack
whats odd is it's showing it's fueling at 49-50% VE, but your maps in that area doesn't ask for that amount.
I'm table switching both spark and VE, triggered by AC. Look at the VE table 3.

The reason I decided to switch VE tables was to get the correct fueling at idle for the spark tables. Previously, switching just the spark tables, I was a bit rich with the AC off and a bit lean with the AC on...

Originally Posted by Braineack
but i realize you're oscillations, now looking at the logs, aren't bad at all.

looks like we are talking +/-50RPM, min the and max RPM is really exaggerating the oscillation. Had that been on a normal log I wouldn't even had seen it.
Oh definitely! Still, I think it could still be smoothed out some more. When logging the idle, I purposely don't rev it up, so these small oscillations come out
Greg G is offline  
Old 06-20-2011, 07:46 PM
  #278  
Boost Czar
iTrader: (62)
 
Braineack's Avatar
 
Join Date: May 2005
Location: Chantilly, VA
Posts: 79,493
Total Cats: 4,080
Default

(zack morris's phone)

No way.
Braineack is offline  
Old 06-21-2011, 11:04 PM
  #279  
Junior Member
 
muythaibxr's Avatar
 
Join Date: May 2007
Location: Columbia, MD
Posts: 248
Total Cats: 0
Default

Greg: you have code waiting in your inbox. Turns out on ms2, only idle was messed up. I had EGO and boost right.

While I was there I boosted the D term a bit for both idle and EGO.

Ken
muythaibxr is offline  
Old 06-21-2011, 11:32 PM
  #280  
Junior Member
Thread Starter
 
Greg G's Avatar
 
Join Date: Jun 2007
Posts: 411
Total Cats: 0
Default

Thanks Ken! But I have a DIYPNP! Could you send me a microsquirt s19? Thanks again!
Greg G is offline  


Quick Reply: DIYPNP install: inital tuning



All times are GMT -4. The time now is 10:28 PM.